• 0 Posts
  • 4 Comments
Joined 1Y ago
cake
Cake day: Jun 22, 2023

help-circle
rss

Yeah, the annoying thing is the people who I generally have found to be the worst about stuff like this are old school Senior C developers, who still program like it’s 1987 and we have to fit everything into 4K of RAM.

Fortunately there’s nothing like that in my code base, I just run into stuff like that periodically when I’m digging around in other team’s server code looking for something.


My personal code readability axe to grind is nested complex ternary operators.

Every now and then I’ll see something like this

return (checkFormatType(currentObject.type==TYPES.static||currentObject type==TYPES.dynamic?TYPES.mutable:TYPES.immutable)?create format("MUTABLE"):getFormat(currentObject));

And I have a fucking conniption because just move that shit into a variable before the return. I get it when sometimes you just need to resolve something inline, but a huge amount of the time that ternary can be extracted to a variable before the ternary, or just rewrite the function to take multiple types and resolve it in the function.


I mean that’s kinda the point the guy you originally replied to was making. From the limited info I’ve seen about this guy I know nothing about him, which isn’t enough for me to dismiss him as a shitty person with just “Nazi bad”. Certainly a good starting point tho lol


I mean there is slightly more to it than just that. Oskar Schindler was a Nazi, is he bad?