• 0 Posts
  • 7 Comments
Joined 1Y ago
cake
Cake day: Dec 09, 2023

help-circle
rss

I’ve had the joy of working on a python project with strict type checking enforced in CI and wow is it a different experience. Am a big fan.



To appeal to people who don’t really understand how stuff works but think GPU is AI and fast


So you never stumbled upon bugs while doing work

That’s not what I said… Either the bug is related to the task, or it isn’t. If it’s not related to the task, there’s no reason to fix it on the same local branch either.

Also, some teams do care about building their work on atomic commits, because they understand the problems caused by mixing up unrelated work on the same PR, specially when auditing changes to track where a regression was introduced. You might feel it’s ok to post a PR that does multiple things like bumping up a package version, linting unrelated code, fixing an issue, and post comments on an unrelated package, but others know those are four separate PRs and should be pushed as four separate PRs.

Well, these things don’t meet the standards of your earlier example at all. Linting unrelated code and posting comments on an unrelated package clearly aren’t needed for someone to work on the main issue fix they’re doing. If it’s unrelated code you again lose nothing by switching branches to do the work.


Oh, okay. I’ve never encountered a situation where I needed that bug fixed for the task but it shouldn’t be fixed as part of the task; if they’re touching the same functionality like that I really don’t see the need for two PRs. But sure, sounds helpful in that really niche case.


I think I understood the example; I think it’s faster to switch branches for the bug-fix than to reorder those commits later


It doesn’t disrupt my workflow to switch branches and it’s much faster than some ugly rebase