For non-trivial reviews, when there are files with several changes, I tend to do the following in Git:
Just curious if this is “a bit weird”, or something others do as well?
(ed: as others mentioned, a squash-merge and reset, or reset back without squashing, is the same, so step 2 isn’t necessary:))
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person’s post makes sense in another community cross post into it.
Hope you enjoy the instance!
Follow the wormhole through a path of communities !webdev@programming.dev
I just comment “Looks good!” and approve.
Same here, unless it’s a small PR then I like to nitpick 👍
As a manager I wait until another engineer approves then comment “lgtm” and approve so the PR hits its two review minimum.