It’s not the real issue. I introduced that while anonymizing the data. It’s that a 3-5 liner code became a huge switch case by just incrementing the code and never thinking how it should be done. This was caused by like 15 engineers in time :)
Something like below would be huge improvement:
subs1 = ["cluster1", "cluster2"]
if subs1.contains(clusterName) return subs1
It is, but If you review 3 lines of pr and not the whole 50 lines of the file without thinking of the overall picture, this happens. I got this while reviewing a pr like this. And most probably I approved similar prs for this file in the past. Shame on me too…
You are not logged in. However you can subscribe from another Fediverse account, for example Lemmy or Mastodon. To do this, paste the following into the search field of your instance: !programmerhumor@lemmy.ml
Post funny things about programming here! (Or just rant about your favourite programming language.)
Rules:
Posts must be relevant to programming, programmers, or computer science.
No NSFW content.
Jokes must be in good taste. No hate speech, bigotry, etc.
How do I view this image in full resolution on Jerboa? Currently only able to see the low res version
There’s a download button in the top right. Not really convenient though, as you then need to go find the downloaded picture yourself.
Thank you, this helps, although jerboa really should have a button for full res right next to the download button.
If any post was ever deserving of a +1 this is it right here.
And no reason to state this is from production.
What am I looking at here? It just always goes to the first case right? 🤔
It’s not the real issue. I introduced that while anonymizing the data. It’s that a 3-5 liner code became a huge switch case by just incrementing the code and never thinking how it should be done. This was caused by like 15 engineers in time :)
Something like below would be huge improvement:
Lol. Dude, you can’t do that to a bunch of coders and not expect them to read it literally.
Yep that’s on me:) let’s call this second breakfast!
Love you fam. :)
no one looks behind and questions how and why.
No time in the development cycle for code review/refactors?
It is, but If you review 3 lines of pr and not the whole 50 lines of the file without thinking of the overall picture, this happens. I got this while reviewing a pr like this. And most probably I approved similar prs for this file in the past. Shame on me too…