million
link
fedilink
English
154
edit-2
1Y

Refactoring is something that should be constantly done in a code base, for every story. As soon as people get scared about changing things the codebase is on the road to being legacy.

@hascat@programming.dev
link
fedilink
English
21Y

Yes please. Many times when I add a feature I end up refactoring some of the code first to better accommodate it.

Who is in the wrong? Your manager, for not giving you time to refactor? Or you for giving him the option?

@nous@programming.dev
link
fedilink
English
71Y

Why do you need time to refactor? It is just part of the work you need to do and should be accounted for when doing any other work. IMO a big mistake people make is thinking refactoring is some separate thing they need permission to do. You don’t, if you need to make a change in some area refactor it first to make it easier to accept your change, then add your change then refactor to clean up. This is not three separate tasks, just three steps in one task. You should be given enough time to do the whole task, not just part of it.

I guess I need to refactor for readability. What you just explained is the entire point of the comment I posted. Refactoring is part of the job. Don’t give your manager a choice on whether or not it needs done.

russ
link
fedilink
English
11Y

We used to call this ‘Code is Cheap’ at my last job - you’re spot on about the value of it

Only if the code base is well tested.

Edit: always add tests when you change code that doesn’t have tests.

And also try to make tests that don’t have to change if you refactor in future (although there are some exceptions)

@NoXzema@lemmynsfw.com
link
fedilink
English
421Y

Been with a lot of codebases that had no unit tests at all and everyone was afraid to change anything because the QA process could take weeks to months.

The result is you have a codebase that ages like milk.

Doesn’t everybody agree with this? I really never thought of it as a hot take.

I highly doubt most corps do

Corps != people.

People just pass the buck and nobody stands up for what is most correct

@bob_wiley@lemmy.world
link
fedilink
English
101Y

deleted by creator

Most calls I have at work are like group therapy sessions, as everyone has ideas of what they believe is correct, but they know if they keep pressing with management or take the time to do what is right, it won’t go well for them.

This is coming from a guy who lasted a year and a half in the office. Sounds like it’s a systematic issue…

@bob_wiley@lemmy.world
link
fedilink
English
21Y

deleted by creator

deleted by creator

FlumPHP
link
fedilink
71Y

Today I removed code from a codebase that was added in 2021 and never ever used. Sadly, some people are as content to litter in their repo as they are in the woods.

thank_you_michael_scott.gif

nomad
link
fedilink
81Y

Our company motto is: “leave it cleaner than you found it”

Create a post

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person’s post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you’re posting long videos try to add in some form of tldr for those who don’t want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



  • 1 user online
  • 1 user / day
  • 1 user / week
  • 1 user / month
  • 1 user / 6 months
  • 1 subscriber
  • 1.21K Posts
  • 17.8K Comments
  • Modlog