public class GameManager : MonoBehaviour
{
    public bool EnableHighContrast;
    public bool PlayerWon;
    public float PlayerUnitsMoved;
    public int PlayerDeathCount;
    public float PlayerHealth;

    public void PlayerTakeDamage(float damage)
    {
        PlayerHealth -= damage;
        if (PlayerHealth < 0)
        {
            PlayerDieAndRespawn();
        }
    }

    public void PlayerDieAndRespawn()
    {
        return;
    }
}

I couldn’t contain myself.

I called the takeDamage function and my player disappeared: send 'elp everything foobar

Don’t worry! this issue will be fixed in the next patch. In the meantime just try not getting hit.

mac
link
fedilink
61Y

The doctor prescribed “getting good”

Too readable, please make each name a paragraph describing its function and how it relates to the other variables/functions around it

Yay, escaped the fight with 0 health!

andrew
link
fedilink
English
51Y

This is floating point. We also need to know what happens when you escape with -0.

Well if you have a “down but not dead” condition then yes, you could escape a fight with 0 health (assuming you have teammates/pawns that can save you).

Wise
link
fedilink
English
571Y

Should it be

PlayerHealth <= 0

?

Otherwise the player could have 0 health and not die? I’m sleep deprived so forgive me if I’m wrong

I know this is /c/Progammerhumor, but I wanted to pull on this thread a little bit for my own edification. I’m a Python guy and have been a while, but I’ve dabbled in other languages. The screenshot says “MonoBehaviour” which makes me assume this is mono or a .Net-like language (you know what happens when you assume).

If your player health is a float, would mono or .Net have an issue comparing the float with integer zero “0”? I mean, it seems like floating point precision may make it impossible for it to ever “equal” integer zero, but it also seems like the code isn’t accounting for that precision error.

Am I overthinking this?

Floating point errors are a product of how floating points work as a mathematical concept. So they’re independent of the programming language and can happen everywhere.

In this case though, I doubt it’s a critical issue. So the player “died” when they actually had 0.000000000027 hp left or whatever. Who cares? Do you need to be that precise?

TipRing
link
fedilink
141Y

Hanging on with 1.70E-31 health.

As a noob in unity and programming, my understanding is that MonoBehavior only means that this script has to be attached as a component to a game object to function. And has no other meaning - but correct me if I’m wrong please.

You are correct.

Wise
link
fedilink
English
541Y

Counting this meme as my first FOSS contribution

Holy shit I was there with you sir! With the zeros and stuff

Open up ticket first, please. Thanks Codemonkey.

@vithigar@lemmy.ca
link
fedilink
12
edit-2
1Y

You are correct about it allowing you to have zero health and not die, but whether or not that’s the correct behavior will depend on the game. Off the top of my head I know that Street Fighter, some versions at least, let you cling to life at zero.

This won’t work if you can ever take more than 1 damage. If you were at 1 and received 2 damage you would become invincible. You’d want to do less than or equal to.

Create a post

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

  • Posts must be relevant to programming, programmers, or computer science.
  • No NSFW content.
  • Jokes must be in good taste. No hate speech, bigotry, etc.
  • 1 user online
  • 62 users / day
  • 133 users / week
  • 396 users / month
  • 2.11K users / 6 months
  • 1 subscriber
  • 1.7K Posts
  • 37.3K Comments
  • Modlog